Quality Goals - A Walkthrough

 

Focus on the leading indicators of quality before production issues happen. Use Hivel's Cockpit screen to track these metrics.

Rework %

• Rework Rate measures the number of changes made to code less than 30 days old.

• Low rework means the code changes aren't done after the initial work, which indicates that the developers are pushing high-quality code the first time.

• High rework rates are caused by PR feedback, QA feedback, or an engineer trying to improve the code after committing. Too many changes.

Maintenance % 

• Maintenance means the lines of code modified that were written before the last 30 days/total lines of code added or modified.

• Less maintenance means that engineers write a very well-maintainable piece of code as the team builds new features.

• Higher maintenance represents a longer time to build new features or testing fatigue. When maintenance is high, estimates are usually off, as it's hard to account for maintenance during estimates.

PRs > 400 Lines of Code 

• If the number of lines added and modified in a PR exceeds 400, it's classified as PRs > 400 Lines of Code.

• PRs > 400 LoC take longer to review, are harder to roll back, and can cause more merge conflict issues. Developers are encouraged to keep PRs smaller, which can move things faster in the pipeline.

PRs merged without review

• All merged PRs that do not have a review state are PRs merged without review.

• Reviewing every PR saves a lot of post-production issues and can keep higher quality across.

• Merging PRs without review is a symptom of production issues or poor-quality code that could lead to higher maintenance issues in the future. Also, junior engineers miss out on learning opportunities.